New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxResponseSize in Future Clients effectively limited to 10 MB by bytes Parser #656

Closed

ksajme opened this issue Jan 8, 2018 · 1 comment

Assignees

Labels

bug

Milestone

ksajme commented Jan 8, 2018 •

edited

Loading

Construction of a Future Client by ClientFactories with an arbitrary maxResponseSize given in a ClientConfig is possible but an exception will be thrown if a response greater than 10 MB is received.
https://github.com/tumblr/colossus/blob/master/colossus/src/main/scala/colossus/util/Parsing.scala#L304

This is due to the following overload which limits the bytes parser to 10 MB:
https://github.com/tumblr/colossus/blob/master/colossus/src/main/scala/colossus/util/Parsing.scala#L323

benblack86 assigned jlbelmonte

Contributor

jlbelmonte commented Jan 11, 2018

Thanks for the report @ksajme. I will look into this.

benblack86 added this to the 0.11.0 milestone

benblack86 added the bug label

jlbelmonte mentioned this issue

increase the parser limit so it always gets overriden by the configu… #664

Merged

benblack86 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment