Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http Header DateFormat Locale #661

Closed
yshyya opened this issue Jan 16, 2018 · 1 comment
Closed

Http Header DateFormat Locale #661

yshyya opened this issue Jan 16, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@yshyya
Copy link

yshyya commented Jan 16, 2018

colossus 0.11.0-M4

My environment (Default Locale = Locale.JAPAN),
"Date" in Http Header has garbled characters.
Because format "EEE" (Day name in week) was converted to non-ASCII characters .

Please consider the following explicit Locale.

Header.scala#L512

val df = new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss z", Locale.ENGLISH)

And CookieExpirationFormat may be too,

Header.scala#L337

 val CookieExpirationFormat = org.joda.time.format.DateTimeFormat.forPattern("E, dd MMM yyyy HH:mm:ss z").withLocale(Locale.ENGLISH)
@benblack86
Copy link
Contributor

Thanks for the report. We should be able to have this in 0.11.0.

@benblack86 benblack86 added this to the 0.11.0 milestone Jan 16, 2018
@benblack86 benblack86 added the bug label Jan 17, 2018
@benblack86 benblack86 self-assigned this Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants