Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove nscala-time #662

Closed
benblack86 opened this issue Jan 17, 2018 · 1 comment
Closed

Remove nscala-time #662

benblack86 opened this issue Jan 17, 2018 · 1 comment
Labels
enhancement good first issue
Milestone
0.12.0

Comments

@benblack86
Copy link
Contributor

We only seem to use it for parsing cookie expire time, which should be possible using standard java libraries. I think this would be good to do since it means one less dependency, one less potential conflict.
@benblack86 benblack86 assigned benblack86 and unassigned benblack86 Jan 17, 2018
@pscheid92
Copy link

I would like to give it a try.
Currently preparing my CLA.

@pscheid92 pscheid92 mentioned this issue Jan 21, 2018
Merged
@benblack86 benblack86 added this to the 0.12.0 milestone Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
2 participants
@benblack86 @pscheid92