Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9:16 Content Editing #105

Closed
bjtitus opened this issue Mar 15, 2021 · 4 comments
Closed

9:16 Content Editing #105

bjtitus opened this issue Mar 15, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request stories Related to the Stories project

Comments

@bjtitus
Copy link
Collaborator

bjtitus commented Mar 15, 2021

  • Restrict Media to 9:16 aspect ratio.
  • Align 9:16 media for devices which are taller than this ratio.

Pan/Zoom Android PR w/ discussions an alignment: Automattic/stories-android#649

@bjtitus bjtitus added enhancement New feature or request stories Related to the Stories project labels Mar 15, 2021
@bjtitus bjtitus self-assigned this Mar 15, 2021
@bjtitus bjtitus added this to To do in WordPress iOS Stories via automation Mar 15, 2021
@bjtitus
Copy link
Collaborator Author

bjtitus commented Mar 15, 2021

After looking at the Android issue for pan/zoom, it looked like the right thing to do was to top align the content. @megsfulton I was hoping you could confirm that's the intent or give some guidance if you think something might need to change for iOS.

This would leave a large black area at the bottom on some taller devices (this is on an 11 Pro):

I looked at a few other options which don't seem much better to me:

Aligning to the top of the bottom story frame area:

Center alignment:

@megsfulton
Copy link
Collaborator

Hm yeah, none of those seem quite right.

Are you able to align the top of the image to the bottom of the status bar? I'm curious if that might be an option that looks okay?

@bjtitus
Copy link
Collaborator Author

bjtitus commented Mar 16, 2021

I can't align it perfectly but can use the top area layout guide to align it, which includes a bit of extra padding below:

This seems to look good on the largest iPhone 12 Pro Max screen as well:

@bjtitus bjtitus moved this from To do to In progress in WordPress iOS Stories Mar 31, 2021
@bjtitus bjtitus moved this from In progress to Done in WordPress iOS Stories Apr 20, 2021
@bjtitus
Copy link
Collaborator Author

bjtitus commented Apr 20, 2021

This was merged in WP iOS 17.2 (wordpress-mobile/WordPress-iOS#16229)

@bjtitus bjtitus closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stories Related to the Stories project
Development

No branches or pull requests

2 participants