Videos have the wrong size when exporting them with a filter #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adriana-elizondo What do you think about gating this change behind the ---let (finalMediaTransform, outputDimensions) = configureScaleToFill(sampleBuffer: sampleBuffer, size: scaleToFillSize)
+++let (finalMediaTransform, outputDimensions) = configureScaleToFill(sampleBuffer: sampleBuffer, size: settings?.features.scaleMediaToFill == true ? scaleToFillSize : nil)---let (finalMediaTransform, outputDimensions) = configureScaleToFill(sampleBuffer: sampleBuffer, size: scaleToFillSize)
+++let (finalMediaTransform, outputDimensions) = configureScaleToFill(sampleBuffer: sampleBuffer, size: settings?.features.scaleMediaToFill == true ? scaleToFillSize : nil) |
yes, you are totally right. Ill update it. Thanks Brandon! |
…nstead behind the scaleMediaToFill flag
Looks good to me!
|
@adriana-elizondo Do you want to make a new version? I think you should be able to just increment the version number like in this commit and the release will be handled. 0dc70d4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After applying a filter to a video, when exporting it the dimensions were wrong.
This PR removes the size specification in the renderer used by the
VideoCompositorso that the default is used.To test it in Orangina:
-Open the editor to create a new post.
-Select a video from your phone or record a new one.
-Add a filter to your video and tap on the blue arrow to select it.
-The size of the video in the editor shouldn't look distorted or different.
-Post the video.
-The video should be posted with the selected filter and the correct dimensions.
-Bonus: try with videos in different orientations and with images and GIFs too, to make sure they weren't affected.