Fast track camera & microphone Permissions #130
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop settings button from being disabled after camera permission has been given but microphone permission hasn't.
This button used to be the camera access button.
The Views have been quite radically changed these should rewritten or rerecorded once the fix is released.
The existing constraints can't handle changes to their size when changing the text.
The button will never be disabled.
Our coding standards are to use the value but we need to use the existing Orangina translations here.
Utilize helper functions and remove redundant accessRequests. Access is now requested upon view appearing.
…ICORE-4182-fast-track-camera-and-microphone-permissions # Conflicts: # KanvasExample/KanvasExample.xcodeproj/project.pbxproj # KanvasExample/KanvasExampleTests/Camera/CameraPermissionsTests.swift
Deco354
changed the base branch from
main
to
declan/ICORE-4872-update-snapshot-library
This functionality is now included within v8.0.0
Replace 10% overall tolerance with 2% perPixel Tolerance
Base automatically changed from
declan/ICORE-4872-update-snapshot-library
to
main
April 22, 2022 06:46
…an/ICORE-4182-fast-track-camera-and-microphone-permissions
|
I've squashed some of the commits and delivered this in to two separate PRs to represent what was and wasn't reviewed within the Orangina PR where we introduced this feature. |
|
Do not delete this branch, we're currently pointing Orangina at it! |
|
In fact I'll reopen this just in case it gets deleted on account of being closed. |
|
Disregard my last comment we're pointing to a different branch. It's all merged so I'll close this and point orangina to the latest update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: ICORE-4812
P2: https://wp.me/pbzQyC-248
What it does
All commits made on or before 5th April have been reviewed as part of this PR. You can filter this PR for April 6th commits onwards (All Tests and code removals) or review the whole thing.
This changes how we ask the user for camera and microphone permissions. Apple recently rejected our review as they didn't want an intermediary screen where users can choose whether to display apples official permission requests.
How to test
Use a real device, resetting the app permission settings on simulator is a bit tricky.
Unknown permissions
Settings > General > Reset > Reset Location & PrivacyAccepted permissions
Settings > General > Reset > Reset Location & PrivacyResult: Camera and mic should be fully accessible
Denied permissions -
Settings > General > Reset > Reset Location & Privacy