Specify editorFonts w/ UIFont & not KanvasTextFont
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to add fonts without having to change the library to handle stringly typed names. The analytics provider will now be responsible for converting the UIFont to a string.
|
@jschementi Not sure if you want to wait until after we release 1.0 (so that there are no changes needed to Orangina) for these changes which alter the public API. |
|
I'd hold off on any public API changes until Orangina is locked to a specific version of Kanvas. So, after launch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
KanvasTextFonttype withUIFonts.This allows us to add fonts without having to change the library to handle stringly typed names.
The analytics provider will now be responsible for converting the
UIFontto a string.Clients implementing
KanvasCameraAnalyticsProviderwill need to do any conversion from theUIFontto an appropriate string for logging. In the example the font's name is used, but a mapping like the previousKanvasTextFontprovided can also be used.