Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.create_photo #36

Closed
Danielez opened this issue Feb 10, 2014 · 7 comments
Closed

client.create_photo #36

Danielez opened this issue Feb 10, 2014 · 7 comments

Comments

@Danielez
Copy link

I've just discovered by trial and error that when using client.create_photo method the data parameter (path to photo) must be str (not unicode). However the caption can be unicode. You should specify when you say "string" what type of string too (str or unicode). Thank you.

@taylanpince
Copy link
Contributor

This really puzzled me as well. You just saved me hours of frustration by opening this issue, thank you.

Documentation should be much more detailed and provide actual examples so people don't fall into this trap.

@Danielez
Copy link
Author

In a parallel universe they have used unicode everywhere from the start and a whole class of encoding related bugs just do not exist, thanks to this fact they already have colonized alpha centauri.

@codingjester
Copy link
Contributor

Quite a fair point on all issues. Once I get some time, I'll address it. 👍

It's true, way over here on Alpha Centauri, we're already just flat out communicating with our minds and a complex sequence of blinking. ;)

@Danielez
Copy link
Author

Just to be clear I was talking about python 2.7 in general. Your library saved me a lot of time, thank you again for your work.

@codingjester
Copy link
Contributor

@DanieleBuffa Thank you for using it. I meant I'll update the docs and make sure it's far more clear and detailed examples. :)

@taylanpince
Copy link
Contributor

Thanks @codingjester - Agreed with @DanieleBuffa your work saved me so much time over the past week! Truly appreciated.

@codingjester
Copy link
Contributor

I updated the docs to be a bit more clear about creating photos and using specific examples on creating a photo.

I haven't gone into unicode vs non-unicode yet, but that'll be next on the list. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants