Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add photoset_layout as an option to create_photo #40

Merged
merged 2 commits into from Jul 3, 2018

Conversation

taylanpince
Copy link
Contributor

Even though this is not a documented feature of the Tumblr API, it works well, and this attribute is actually provided by their Posts endpoint (http://www.tumblr.com/docs/en/api/v2#posts)

Allowing this photoset_layout option as a valid attribute to create an image post would be a nice addition since it gives full control over how photos are laid out in the template.

@taylanpince
Copy link
Contributor Author

I just noticed that my other other commit also sneaked in here. To explain: I noticed that if I provide an empty tags list, Tumblr API responds with an Authentication error. Probably an issue related to the way the request is signed. I added a sanity check to prevent this issue, it was quite puzzling.

@codingjester
Copy link
Contributor

Good call on the tag list. Can you do me a favor and add a test for this to make sure the web request doesn't send the empty tag list? Once you have that, I think we're ok to pull you in.

@alikaragoz
Copy link

Thanks @taylanpince very useful 👍

@taylanpince
Copy link
Contributor Author

@codingjester For sure, I'll handle this over the weekend.
@alikaragoz Thanks!

@jasonpenny
Copy link
Contributor

I know this pull request is very old, but we will need a signed CLA to pull this in

@yahoocla
Copy link

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@taylanpince
Copy link
Contributor Author

@jasonpenny I don't even remember opening this PR, but sure, I signed the CLA 😄

@jasonpenny
Copy link
Contributor

haha, thanks!

@jasonpenny jasonpenny merged commit 7654e63 into tumblr:master Jul 3, 2018
jasonpenny added a commit that referenced this pull request Jan 8, 2019
Fix build broken when #40 was merged; add python 3.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants