Python 2/3 support for PyTumblr.

[dianakhuang]

I have updated the PyTumblr code to be both backwards compatible with Python 2 and forwards compatible with Python 3.

Some notes about what I've done:

• Since the oauth2 library isn't Python 3 compatible, I've ripped it out and replaced it with requests-oauthlib, which has cleaned up the multipart posting quite a bit.
• I've used the future library to be the compatibility layer for both Python 2 and Python 3, hence I've added it as a requirement.
• I have done some manual testing in both Python 2 and 3 to ensure that the major functionality is still working the way we'd expect, including file uploads.
• It seems like HTTPretty is giving us back values as Python bytestrings, so I had to update the tests to reflect that. If this is a concern, let me know.
• There's some issues with running the tests under 3.4 due to how HTTPretty does its mocking of sockets (see this issue for more details), so I've only added 3.3 to be run on Travis. The client itself runs fine under Python 3.4.
• There's also a few minor PEP8 fixes that I've tossed in as well.

I'm reading over the CLA right now. I'll try to get it sent in on Tuesday if you're are interested in ever trying to merge this. I'm happy to make updates based on any code review feedback you may have.

[yl3w]

@codingjester

[midopa]

+1

[codingjester]

This LGTM, we should pull it in and try to cut a new release.

[dianakhuang]

Sounds good to me. I submitted a CLA a bunch of months back. Let me know if I need to do anything else.

[fake-name]

Hello? Is this dead in the water?

No repo updates in the last 8 months.

---

@dianakhuang - For your py3k branch, don't forget to patch interactive_console.py. A simple 2to3 doesn't properly fix it, it does a bunch of oauth stuff I don't really understand at the moment.

[afk-mario]

I migrated to https://github.com/michaelhelmick/python-tumblpy

[dianakhuang]

Whoa, sorry I missed your comment @fake-name . If you check out the diff, I did redo a bunch of interactive_console.py because this change isn't just a simple 2to3 conversion. I had to replace the oauth2 library with requests-oauthlib because oauth2 (at least when I wrote this PR) doesn't/didn't support Python 3.

[pepoluan]

Why is this not yet merged?

[colindickie]

I've successfully modified the code to work on Python 3.5. It works fine on 'Text Posts' but 'Photo Posts' returns '401 Unauthourised' is this a 2/3 problem, or can anyone help? Thank you

[blairg23]

Why are we still having this problem a year later?

[newfurniturey]

Holy 2-year delay, Batman! Still looks good to me =P

@jasonpenny Wanna merge and bring this repo back to life?

[jasonpenny]

💥

@colindickie I know it's been a while, but I couldn't reproduce the problem you had. If it is still happening for you, please open an issue with some more detail