-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not all whitelists are processed #22
Comments
Can you test this beta version if I was able to fix it: |
You did it :) Nice job Now only the "cache" problem persist... I mentioned in quotes because I don't know yet where the problem is (FF or RC). |
Good to hear! 👍 Yes, please open a new issue for it. If you can give me steps to reproduce the issue that helps a lot. |
fixed in 1.7.1 |
Create following rules... order of creation is important:
1.
Pattern: Any
Types: Image
Action: Filter
Filter URL: Off
Trim URL Parameters: Trim all
Pattern scheme: http/https
Pattern host: *
Pattern path: test*,xxxxx* (actually just fill something)
Types: Any type
Action: Whitelist
Pattern scheme: http/https
Pattern host: ksr-ugc.imgix.net
Pattern path: *
Types: Image
Action: Whitelist
Now visit https://www.kickstarter.com/, scroll a bit down and you will see missing images, which were junked by rule 1.
But, since we have rule 3, those images should have been whitelisted.
If we disable rule 2, then rule 3 kicks in and images are shown as they should (OK some does not, I believe because of cache or something... but this should be covered in another topic... if Firefox is restarted then it works).
So, I assume that when whitelist rule 2 is processed (doesn't matter if matched or not) then whitelist rule 3 is not processed but should have been.
NOTE: I am using RC 1.7.0beta3
The text was updated successfully, but these errors were encountered: