Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all whitelists are processed #22

Closed
crssi opened this issue Jun 30, 2017 · 4 comments
Closed

Not all whitelists are processed #22

crssi opened this issue Jun 30, 2017 · 4 comments
Labels

Comments

@crssi
Copy link
Contributor

crssi commented Jun 30, 2017

Create following rules... order of creation is important:
1.
Pattern: Any
Types: Image
Action: Filter
Filter URL: Off
Trim URL Parameters: Trim all

Pattern scheme: http/https
Pattern host: *
Pattern path: test*,xxxxx* (actually just fill something)
Types: Any type
Action: Whitelist

Pattern scheme: http/https
Pattern host: ksr-ugc.imgix.net
Pattern path: *
Types: Image
Action: Whitelist

Now visit https://www.kickstarter.com/, scroll a bit down and you will see missing images, which were junked by rule 1.
But, since we have rule 3, those images should have been whitelisted.
If we disable rule 2, then rule 3 kicks in and images are shown as they should (OK some does not, I believe because of cache or something... but this should be covered in another topic... if Firefox is restarted then it works).
So, I assume that when whitelist rule 2 is processed (doesn't matter if matched or not) then whitelist rule 3 is not processed but should have been.

NOTE: I am using RC 1.7.0beta3

@tumpio tumpio added the bug label Jun 30, 2017
@tumpio
Copy link
Owner

tumpio commented Jun 30, 2017

Can you test this beta version if I was able to fix it:
https://addons.mozilla.org/addon/requestcontrol/versions/1.7.1beta1

@crssi
Copy link
Contributor Author

crssi commented Jun 30, 2017

You did it :) Nice job

Now only the "cache" problem persist... I mentioned in quotes because I don't know yet where the problem is (FF or RC).
Should I open new Issue?

@tumpio
Copy link
Owner

tumpio commented Jun 30, 2017

Good to hear! 👍

Yes, please open a new issue for it. If you can give me steps to reproduce the issue that helps a lot.

@tumpio
Copy link
Owner

tumpio commented Jul 8, 2017

fixed in 1.7.1

@tumpio tumpio closed this as completed Jul 8, 2017
Repository owner locked and limited conversation to collaborators Jul 23, 2017
@tumpio tumpio removed the help wanted label Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants