Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precision problems on M1 Mac GPU #92

Closed
tuner opened this issue Mar 21, 2022 · 2 comments
Closed

Precision problems on M1 Mac GPU #92

tuner opened this issue Mar 21, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@tuner
Copy link
Member

tuner commented Mar 21, 2022 •
edited

It appears that LUMA_FP64_CODE_ELIMINATION_WORKAROUND is not effective enough in:
https://github.com/genome-spy/genome-spy/blob/master/packages/core/src/gl/includes/fp64-arithmetic.glsl

This affects both Safari and Chrome.

Have to either:

  1. Do something for the workaround
  2. Replace fp64 with something completely diffferent. We don't need full 64 bit precision. It's enough to be able to zoom and translate the genomic axis.
@tuner tuner added the bug Something isn't working label Mar 21, 2022
@tuner tuner changed the title Precision problems on M1 Mac and Safari Precision problems on M1 Mac GPU Mar 24, 2022
@tuner tuner closed this as completed in 2aade84 Apr 7, 2022
@tuner
Copy link
Member Author

tuner commented Apr 8, 2022

Appears to not be fixed:
image

@tuner tuner reopened this Apr 8, 2022
@tuner
Copy link
Member Author

tuner commented Apr 11, 2022

Finally fixed by 6e5c1dc

@tuner tuner closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tuner