You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have looked at the PR (https://gerrit.tungsten.io/r/c/docs/+/37) associated with this issue and I would recommend we take a bit of a different approach. The PR essentially adds the tf-devstack code to the docs repo. This is not the approach we would like to take, so I have extracted the contents of the patch which Nishita has submitted and compared it against the current master branch for the upstream tf-devstack repo to understand the changes which were intended to be introduced.
I have isolated the proposed changes down to the following patch:
I am going to revoke the PR, https://gerrit.tungsten.io/r/c/docs/+/37, as it does not conform to the documentation strategy we are trying to establish. I will leave this Jira issue open as we still have an open issue on improving the tf-devstack documentation.
I am going to approve and merge the PR, https://gerrit.tungsten.io/r/c/docs/+/36, as it introduces a valid reference to the documentation which we currently are missing in that repo. I will create another PR to then update the contents of that PR to conform to the new RTD format we are adopting, but I want Nishita's contribution to be formally merged and I will handle the clean up to make it conform to our current practices as another commit.
Add a quick start guide for using Tungsten Fabric using TF-Devstack and upgrades for Contrail Ansible deployer - k8 and Openstack.
The text was updated successfully, but these errors were encountered: