This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
FusedAdam & CPUAdam #120
Merged
FusedAdam & CPUAdam #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cozytk Can we merge this now? |
|
@hyunwoongko Yes. It passes all tests and just few review points left filesoslo/torch/_C/init.py
oslo/torch/nn/parallel/data_parallel/sharded_data_parallel.py
oslo/torch/optim/cpu_adam.py
|
|
|
@hyunwoongko Done! |
hyunwoongko
reviewed
Jun 2, 2022
| @@ -0,0 +1,214 @@ | |||
|
|
|||
| @@ -0,0 +1,36 @@ | |||
| #pragma once | |||
cozytk
commented
Jun 2, 2022
| #include "cublas_v2.h" | ||
| #include "cuda.h" | ||
| #include "curand.h" | ||
| #include "gemm_test.h" |
There was a problem hiding this comment.
@hyunwoongko çpu_adam.h requires context.h. context.h requires gemm_test.h
cozytk
commented
Jun 2, 2022
| #pragma once | ||
|
|
||
| #include "StopWatch.h" | ||
| #include "cublas_wrappers.h" |
There was a problem hiding this comment.
@hyunwoongko gemm_test.h includes cublas_wrappers.h
hyunwoongko
reviewed
Jun 2, 2022
|
|
||
| void SetSeed(uint64_t new_seed) { _seed = new_seed; } | ||
|
|
||
| void TestGemmFP16(bool test_gemm, int batch_size, int seq_len, int head_num, |
There was a problem hiding this comment.
You can remove this. no?
There was a problem hiding this comment.
@hyunwoongko I'm gonna apply it!
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
-FusedAdam & CPUAdam
Description
Tasks