Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhacements] Is it ok to replace all the ScriptName vars for the general ScriptName var? #35

Closed
ordonezgs opened this issue Jul 22, 2020 · 1 comment
Closed

[Enhacements] Is it ok to replace all the ScriptName vars for the general ScriptName var? #35

ordonezgs opened this issue Jul 22, 2020 · 1 comment
Assignees
@ordonezgs
Labels
enhancement New feature or request feature_request

Comments

@ordonezgs
Copy link
Collaborator

There are 7 unused cases of the already declared script var.

WME-send-to-slack/WME-send-to-slack.user.js

Line 144 in a8c0ef4

var ScriptName = GM_info.script.name;

@ordonezgs ordonezgs added the enhancement New feature or request label Jul 22, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.69. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@ordonezgs ordonezgs changed the title [Enhacements] Is it ok to replace all the ScriptName vars for the general ScriptName var [Enhacements] Is it ok to replace all the ScriptName vars for the general ScriptName var? Jul 22, 2020
ordonezgs added a commit to ordonezgs/WME-send-to-slack that referenced this issue Jul 22, 2020
@ordonezgs
Update WME-send-to-slack.user.js
3c2a0cf 
Solved tunisiano187#35 tunisiano187#29
@ordonezgs ordonezgs mentioned this issue Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ordonezgs ordonezgs

Labels
enhancement New feature or request feature_request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tunisiano187 @ordonezgs