Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving importers #717

Open
AsgardXIV opened this issue Jul 28, 2023 · 2 comments
Open

Consider moving importers #717

AsgardXIV opened this issue Jul 28, 2023 · 2 comments
Labels
improvement Improvements to an existing feature

Comments

@AsgardXIV
Copy link

It's really great that you have built in support in the editor for various formats, particularly VRM.

For folks who are building games or projects where there is user-generated content and they want to allow people to use their VRMs etc, it would be great to have the importers accessible outside the editor.
The easiest way of currently doing this is just copying the code from the editor, but obviously that has high maintenance overhead.

The simplest change would likely be to move the glTF/VRM/OBJ importers from the Editor to the Engine itself, perhaps behind a flag so anyone building the engine can choose to include them or not.
Alternatively they could be a separate project that layers on top of the engine and is consumed in the editor / game that wants them.

Do you have any thoughts of if this is a good idea and an approach that might work?

@turanszkij turanszkij added the improvement Improvements to an existing feature label Jul 29, 2023
@turanszkij
Copy link
Owner

turanszkij commented Jul 29, 2023

My reason was that I want users to use the wiscene format in their games, because it's the native scene format that is fastest to load, and it's possible to manage versioning for assets. Versioning means that wiscene from an older engine version will work the same way in newer engine version, but this can not be said about outside model formats as there are occasional importer changes. But I will reconsider.

For now, you don't need to copy the asset importer file though, you can simply include it in your build from the Editor directory as well if you want. Actually the Imgui Docking example does this, so you can take a look.

@AsgardXIV
Copy link
Author

I got including them in my build working, not sure why I didn't think of that.

I understand the reasoning for not wanting it in the core engine. I do think there is value in considering a more clearly defined way to include optional stuff from the editor for games to consume where it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants