Fix unsync() combined with cursorSync

jieter · May 19, 2016 · 5cb382d · 5cb382d
1 parent 0a9261d
commit 5cb382d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 13 deletions.
diff --git a/L.Map.Sync.js b/L.Map.Sync.js
@@ -33,24 +33,28 @@
             if (options.syncCursor) {
                 map.cursor = L.circleMarker([0, 0], options.syncCursorMarkerOptions).addTo(map);
 
-                var cursors = this._cursors;
-                cursors.push(map.cursor);
+                this._cursors.push(map.cursor);
 
-                this.on('mousemove', function (e) {
-                    cursors.forEach(function (cursor) {
-                        cursor.setLatLng(e.latlng);
-                    });
-                });
-                this.on('mouseout', function (e) {
-                    cursors.forEach(function (cursor) {
-                        // TODO: hide cursor in stead of moving to 0, 0
-                        cursor.setLatLng([0, 0]);
-                    });
-                });
+                this.on('mousemove', this._cursorSyncMove, this);
+                this.on('mouseout', this._cursorSyncOut, this);
             }
             return this;
         },
 
+        _cursorSyncMove: function (e) {
+            this._cursors.forEach(function (cursor) {
+                cursor.setLatLng(e.latlng);
+            });
+        },
+
+        _cursorSyncOut: function (e) {
+            this._cursors.forEach(function (cursor) {
+                // TODO: hide cursor in stead of moving to 0, 0
+                cursor.setLatLng([0, 0]);
+            });
+        },
+
+
         // unsync maps from each other
         unsync: function (map) {
             var self = this;
@@ -65,6 +69,8 @@
                     }
                 });
             }
+            this.off('mousemove', this._cursorSyncMove, this);
+            this.off('mouseout', this._cursorSyncOut, this);
 
             return this;
         },

diff --git a/examples/syncCursor_dual.html b/examples/syncCursor_dual.html
@@ -46,6 +46,12 @@
         map1.sync(map2, {syncCursor: true});
         map2.sync(map1, {syncCursor: true});
 
+        // unsync after 5s.
+        setTimeout(function () {
+            map1.unsync(map2);
+            map2.unsync(map1);
+        }, 5000);
+
     </script>
 </body>
 </html>