Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail early when exceeding maximum lengths #23

Open
mappum opened this issue Sep 5, 2019 · 0 comments
Open

Fail early when exceeding maximum lengths #23

mappum opened this issue Sep 5, 2019 · 0 comments
Projects

Comments

@mappum
Copy link
Collaborator

mappum commented Sep 5, 2019

We use pretty conservative maximum lengths (255 bytes for keys, 65,535 bytes for values) for simplicity, compactness in the encoding, and to encourage efficient usage (large keys degrade performance and take up a lot of space in proofs). I could see these limits eventually changing if really necessary, but I'd like to keep them for now.

However, the limits are currently only enforced by panicking when encoding nodes - we should have earlier checks for these limits which error rather than panic.

@mappum mappum added this to To do in Merk Werk Nov 16, 2019
@mappum mappum moved this from To do to To do (Next release) in Merk Werk Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Merk Werk
  
To do (Next release)
Development

No branches or pull requests

1 participant