Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null JSON value not visible in output on dark mode terminal #829

Open
e-gineer opened this issue Apr 3, 2024 · 2 comments
Open

null JSON value not visible in output on dark mode terminal #829

e-gineer opened this issue Apr 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@e-gineer
Copy link
Contributor

e-gineer commented Apr 3, 2024

Here is what I see:
image

Here is the actual text copied out:

[approve] Output result = {
  "label": "Skip",
  "style": null,
  "value": "skip"
}
@e-gineer e-gineer added the bug Something isn't working label Apr 3, 2024
@graza-io
Copy link
Contributor

graza-io commented Apr 4, 2024

This seems to stem from where we replicated the go-prettyjson colors (but we removed the bold):

The code is in pipe-fittings where it uses FgBlack for the null color - comparison against go-prettyjson here

Note: This means it works fine on a light background but default dark background & tango dark make this text invisible (as I'm sure some other themes do)

We could make this "BrightBlack" (aka grey) or one of the other ANSI colors that has more contrast against default black/white backgrounds?

Copy link

github-actions bot commented Jun 4, 2024

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jun 4, 2024
@graza-io graza-io removed the stale label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants