Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use concaveman! #11

Closed
tmcw opened this issue Feb 16, 2016 · 3 comments
Closed

Use concaveman! #11

tmcw opened this issue Feb 16, 2016 · 3 comments

Comments

@tmcw
Copy link
Contributor

tmcw commented Feb 16, 2016

@mourner made concaveman - let's use it!

@mourner
Copy link

mourner commented Feb 16, 2016

I'd be happy to see it used here, as it's orders of magnitude faster. It should be noted though that there are disadvantages too:

  • there are two tuning parameters (concavity and lengthThreshold) that are both not very intuitive, so we would have to make the API less straightforward or settle on some defaults
  • the output may be less "optimal" because it's not based on Delaunay triangulation, although I'm not sure — needs some comparisons

@kelvinabrokwa
Copy link
Contributor

@mourner @morganherlocker it looks like concaveman doesn't behave in the same way that the current implementation does. For example, it never creates islands (multipolygons) whereas turf-concave, under certain conditions, will.

@morganherlocker also tells me this is not a thing in turf ⬇️

@tmcw
Copy link
Contributor Author

tmcw commented Apr 25, 2016

Implemented in https://github.com/Turfjs/turf

@tmcw tmcw closed this as completed Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants