Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOTP addon icon doesn't show #3

Open
galmok opened this issue Sep 19, 2023 · 3 comments
Open

TOTP addon icon doesn't show #3

galmok opened this issue Sep 19, 2023 · 3 comments

Comments

@galmok
Copy link

galmok commented Sep 19, 2023

Using Firefox 117.0.1, the TOTP installs just fine, but it doesn't show the TOTP icon on the toolbar.

Without that icon, this addon is virtually useless. :-(

The icon does show in Firefox 88, but in that version it isn't able to look up the saved keys even. Old browser, just to show that the icon does show up in the old browser but not in the new.

@turistu
Copy link
Owner

turistu commented Sep 19, 2023

but it doesn't show the TOTP icon on the toolbar.

You're supposed to "pin" it yourself to the toolbar. See the screen recording.

That's how the firefox's interface works -- not something that I can change or something that I had decided on.

@galmok
Copy link
Author

galmok commented Sep 19, 2023

Hmm thank you for teaching me the ways of Firefox. I must have forgotten how to do it as I have a number of addons showing an icon on my toolbar... But it worked and awarded the addon 5 stars because it is simple to use, stores keys securely, and requires no permissions. Well done. :)

@turistu
Copy link
Owner

turistu commented Sep 19, 2023

I must have forgotten how to do it as I have a number of addons showing an icon on my toolbar...

Actually, there is a way to force it to the navigation bar directly upon install via the default_area manifest key. Those extensions might use it, that's probably why you didn't notice it. I'll use it too -- see 7156b05.

The icon does show in Firefox 88, but in that version it isn't able to look up the saved keys even.

I have tested it in Firefox 88 (with a clean profile, in a debian 10 vm) and it seems to work. It would be interesting to know if there are other browser settings (besides signon.rememberSignons = false) which interfere with it.

It is older versions (like 68.6.0esr) which have problems because of some javascript & css features which didn't exist at the time. Got rid of them in 9210c96 and ec74393.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants