Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix suggestion: insert i #96

Open
luisfvieirasilva opened this issue May 24, 2023 · 1 comment
Open

Fix suggestion: insert i #96

luisfvieirasilva opened this issue May 24, 2023 · 1 comment

Comments

@luisfvieirasilva
Copy link

luisfvieirasilva commented May 24, 2023 •
edited
Loading

The suggester is wrong for the input insert i
Current suggestion: insert
Expected suggestion: into

We have a commented test for this at ./libsql-shell/internal/suggester/suggester_test.go. Please comment this out once it's fixed.
@douglasmdev
Copy link
Contributor

douglasmdev commented May 30, 2023 •
edited
Loading

Might be worth taking a look at this bug as well:

Screencast.from.30-05-2023.10.47.14.webm

Seems the suggester does not consider spaces as an end-of-token.

@douglasmdev douglasmdev mentioned this issue May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luisfvieirasilva @douglasmdev