Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X64 Mac users are getting "Error: Cannot find module '@libsql/darwin-x64'" #1474

Open
rathboma opened this issue Jun 13, 2024 · 5 comments
Open

Comments

@rathboma
Copy link
Contributor

rathboma commented Jun 13, 2024

Hi folks,

I'm bundling LibSQL inside Beekeeper Studio. It works fine on Mac M1, Linux, Windows, but does NOT seem to work on Intel Macs. Here's my user report

All my other native modules work, but for some reason @libsql/darwin-x64 is not getting bundled.

Seems like someone else had this issue in the past but it was not officially resolved.

Hoping you can direct me to the right way to fix this? I don't really know what else to do tbh.

@rathboma
Copy link
Contributor Author

Did something change after 0.3.4?

@penberg
Copy link
Collaborator

penberg commented Jun 13, 2024

@rathboma The package does exist and is up-to-date: https://www.npmjs.com/package/@libsql/darwin-x64?activeTab=versions There's nothing specific about the Darwin/x64 build either... 🤔

@rathboma
Copy link
Contributor Author

Hey, I did some tests and it might be an electron-builder quirk, not sure. This is the deal:

  • We build Mac packages on a ARM64 M1 machine, we build for both architectures simultaneously.

  • Builds made in this way are not working on x86_64 machines with libsql.

  • SQLite, Oracle, and other libs with native dependencies do package themselves just fine with this set-up. So there's potentially something a little different about how y'all are handling native deps for Mac.

  • If I build directly on a x86_64 mac, the build works fine.

Could it be that darwin-x64 is only installed when running on an intel mac, vs any mac?

@HameArm
Copy link

HameArm commented Jun 14, 2024

Did you build the previous version differently? That was working fine..

@rathboma
Copy link
Contributor Author

rathboma commented Jun 14, 2024

@HameArm the previous version didn't include LibSQL. This is a new problem exclusively on LibSQL.

@penberg Can you point me to where @libsql/darwin-x64 gets used? Maybe I need to explicitly include it or something?

To be clear -- this is an issue for any electron developer looking to create universal mac builds, or create an x64 build on an M1 chip (which is now the recommended way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants