Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support webhooks #50

Closed
turt2live opened this issue Mar 26, 2017 · 2 comments
Closed

Support webhooks #50

turt2live opened this issue Mar 26, 2017 · 2 comments
Labels
bot enhancement
Milestone
v1.1.0

Comments

@turt2live
Copy link
Owner

turt2live commented Mar 26, 2017 •
edited
Loading

For when new nodes and links are discovered
@turt2live turt2live added this to the v2 milestone Mar 26, 2017
@turt2live turt2live removed this from the v2 milestone Apr 17, 2017
@turt2live turt2live modified the milestones: v2, v1.1.0, After v1.1.0 Apr 17, 2017
@turt2live
Copy link
Owner Author

note to self: This is outgoing webhooks

@turt2live turt2live modified the milestones: After v1.1.0, v1.1.0 Dec 12, 2017
@turt2live
Copy link
Owner Author

I've been thinking about this for the last couple months and I think it's best if it isn't implemented. The rationale is that rooms should have an opportunity to take themselves out of Voyager, and a webhook being fired doesn't really help with that.

There's the risk that the room's metadata would be leaked because the API is being polled still. Broadcasting that metadata isn't in the best interest of the bot as of right now. This may be something to consider in the distant future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bot enhancement
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@turt2live