Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@tus/s3-store: fix uncaught exception when removing files #410

Merged
merged 1 commit into from Mar 13, 2023

Conversation

fenos
Copy link
Collaborator

@fenos fenos commented Mar 13, 2023

Fixes #409

@Murderlon Murderlon changed the title fix: uncaught exception when removing files @tus/s3-store: fix uncaught exception when removing files Mar 13, 2023
@Murderlon Murderlon merged commit 89367b5 into tus:main Mar 13, 2023
@Murderlon
Copy link
Member

Thanks for looking into this!

@fenos
Copy link
Collaborator Author

fenos commented Mar 13, 2023

@Murderlon no worries!

Could you please cut a release with this fix 🙏

@Murderlon
Copy link
Member

Here it is https://github.com/tus/tus-node-server/releases/tag/%40tus%2Fs3-store%401.0.0-beta.4 :)

Murderlon added a commit to mitjap/tus-node-server that referenced this pull request May 16, 2023
* main:
  Bump typescript from 4.9.3 to 5.0.4 (tus#425)
  Bump sinon from 15.0.0 to 15.0.4 (tus#426)
  @tus/gcs-store: allow user to pass bucket instance to GCSStore (tus#388)
  Fix e2e test typecheking (tus#429)
  Update incorrect comment (tus#430)
  @tus/s3-store: add missing error code in termination extension (tus#413)
  @tus/s3-store@1.0.0-beta.5
  @tus/s3-store: fix uncaught exception when cancelling an upload (tus#412)
  @tus/s3-store@1.0.0-beta.4
  @tus/s3-store: fix uncaught exception when removing files (tus#410)
  @tus/s3-store: add termination extension (tus#401)
  @tus/server@1.0.0-beta.5
  Bump @google-cloud/storage from 6.8.0 to 6.9.3 (tus#404)
  Bump http-cache-semantics from 4.1.0 to 4.1.1 (tus#393)
  Bump eslint-config-prettier from 8.5.0 to 8.6.0 (tus#392)
  Bump cookiejar from 2.1.3 to 2.1.4 (tus#383)
  Bump aws-sdk from 2.1269.0 to 2.1325.0 (tus#403)
  @tus/server: refactor and improve request validator (tus#402)
  Fix demo (tus#386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server crashes when killing client upload - S3 Store
2 participants