@tus/server: do not emit chunkFinished on error

[fenos]

Related to #444

If an error occurs during the write stream, we don't want to broadcast the chunkFinished event.
This should fix potential race conditions

[Murderlon]

Thanks a lot for looking into this!

[Murderlon]

CI fails on the linter currently

[fenos]

@Murderlon actually, I think a cleaner way to handle this is to have its own error handler function instead of mixing it into the _finishChunk function, for example:

  async _handleError() {
    if (this.fileHandle === null) {
      return
    }

    await this.fileHandle.close()
    this.currentChunkPath = null
    this.fileHandle = null
  }

It feels cleaner doing it this way, since we don't even need to advance the part to next chunk either.

[Murderlon]

Thank you!

[Murderlon]

@Murderlon actually, I think a cleaner way to handle this is to have its own error handler function instead of mixing it into the _finishChunk function, for example:

Probably a bit cleaner yes. Let's add it.

[fenos]

@Murderlon Just sent the patch using its dedicated error handler function

[Murderlon]

Released https://github.com/tus/tus-node-server/releases/tag/%40tus%2Fserver%401.0.0-beta.6