Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump crypto version #786

Closed
sdhull opened this issue Aug 10, 2022 · 2 comments
Closed

Bump crypto version #786

sdhull opened this issue Aug 10, 2022 · 2 comments
Labels

Comments

@sdhull
Copy link

sdhull commented Aug 10, 2022

Describe the bug
I don't think that tusd uses crypto/ssh (and is therefore not really subject to this CVE) however from a static analysis standpoint it'd be nice if we could pull in a version of this library that isn't flagged as vulnerable.

I'm not super familiar with golang, so not sure how hard this is to do, as this is a dependency of a dependency.

To Reproduce
See https://security.snyk.io/vuln/SNYK-GOLANG-GOLANGORGXCRYPTOSSH-551923

@sdhull sdhull added the bug label Aug 10, 2022
@Acconut
Copy link
Member

Acconut commented Sep 9, 2022

To be honest, I am not an expert with Go dependencies. I tried to follow the steps in https://medium.com/@majdasab/how-to-upgrade-an-indirect-dependency-in-golang-988751f92a6e to require a version of crypto that fixes this issue, but the Go tool chain always overwrites my changes. So maybe we already use a new enough version. But I personally do not know how to tackle this.

@sdhull
Copy link
Author

sdhull commented Sep 12, 2022

@Acconut thank you so much for looking into this. I've also chatted with golang folks at my company it and it sounds like this is not really possible (and is a widespread issue in the go ecosystem). I'm going to close this for now. Thanks again for looking into it ❤️

@sdhull sdhull closed this as completed Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants