Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnFileCompleteAsync never gets fired when uploading a file with size 0. #119

Closed
oquirion opened this issue Jan 20, 2021 · 4 comments
Closed
Labels
Milestone

Comments

@oquirion
Copy link

Using version 2.2.1 of tusdotnet.
Step to reproduce:

  1. Create new text file name 'empty.txt' without writing anything to it.
  2. Try to upload the file.

If you need more specification, just poke me.
I've haven't seen the bug reported, nor corrected in the last 2 release.
I'm waiting for you call on it.

Best regards,
Oliver

@smatsson
Copy link
Collaborator

Haha I love this bug. :D What was your use case when you found this?

@smatsson smatsson added the bug label Jan 21, 2021
@oquirion
Copy link
Author

Actually, I've found out the bug out of pure luck. We're using tus library to perform file upload and as I was manually testing it, I accidently tried to send a brand new txt file that was lying around on my desktop and it failed. I've quickly created a bug issue on Jira before forgetting about it (because it's such an edge case). So here I am, a few weeks from then, I've just debugged it down to tus library. I was looking on github to see if it has been reported/fix in the latest release and if the whole project was still alive. I'm glad someone pick up the phone!! Do you need anything to help you reproduce it?
Regards,

@smatsson
Copy link
Collaborator

I think I'm good right now to reproduce it and will look into it as soon as I get the time. Thanks for reporting!

@smatsson smatsson added this to the 2.3+1 milestone Jan 25, 2021
@oquirion
Copy link
Author

Thank you very. I'll update the lib and test it in our env.
Regards'
Oli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants