Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When Carousel is a single picture, or do I not need dot existence? #1777

Closed
Air-Cooled opened this issue Dec 7, 2021 · 9 comments · Fixed by #2141
Closed

When Carousel is a single picture, or do I not need dot existence? #1777

Air-Cooled opened this issue Dec 7, 2021 · 9 comments · Fixed by #2141
Labels
feature request New feature or request

Comments

@Air-Cooled
Copy link

TuSimple/naive-ui version (版本)

2.21.5

Vue version (Vue 版本)

3.2.24

Reappearance steps (重现步骤)

Use Carousel

Expected results (期望的结果)

Can control whether the dot the Carousel are displayed

Actual results (实际的结果)

The dot of Carousel must exist
@Air-Cooled Air-Cooled changed the title When 'Carousel' is a single picture, or do I not need dot existence? When Carousel is a single picture, or do I not need dot existence? Dec 7, 2021
@github-actions github-actions bot added the untriaged need to sort label Dec 7, 2021
@Talljack
Copy link
Contributor

Talljack commented Dec 8, 2021

If you think it's a bug, please provide demo, convenient for us to quickly troubleshoot bug

@Air-Cooled
Copy link
Author

If don’t think need a scenario that does not show dot, can turn it off

@Talljack
Copy link
Contributor

Talljack commented Dec 8, 2021

will do, ref #1462

@Talljack Talljack added feature request New feature or request and removed untriaged need to sort labels Dec 8, 2021
@nooooooom nooooooom mentioned this issue Dec 29, 2021
Merged
@Sepush
Copy link
Collaborator

Sepush commented Jan 10, 2022

still not fixed

@Sepush Sepush mentioned this issue Jan 10, 2022
Merged
@ruihildt
Copy link

I have a usecase where I don't want dot at all. I would like to have a props where I can hide them.

Would that be possible?

@Sepush
Copy link
Collaborator

Sepush commented Jan 27, 2022

I have a usecase where I don't want dot at all. I would like to have a props where I can hide them.

Would that be possible?

set dot-type to never

@07akioni
Copy link
Collaborator

set show-dots to false

@07akioni
Copy link
Collaborator

07akioni commented Jan 28, 2022 •
edited
Loading

doc has some mistakes, I've fixed it

@ruihildt
Copy link

Thank you. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(carousel): when single pic should with no dot Sepush/naive-ui
5 participants
@ruihildt @07akioni @Talljack @Sepush @Air-Cooled