-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance ellipsis component #75
Comments
As far as I know there would be some edge cases for js dom slicing and measuring based ellipsis. For example non-text inline element is hard to deal with. (and i think it may break vue's patching phase (when user changes slot content). I'm not planning to do it. However if you have knowledge about how to solve those problems. PR is welcomed. |
@07akioni I agree with you, how to judge the row count(1 or multiple of text's line-height) of a non-text inline element(higher than text) is divergent. I compute total height by text's line-height and line-clamp in |
I think it's okay. If you want to use custom ellipsis, you need to ensure only text is passed in. |
What problem does the feature solve?
Refer to react-ellipsis.
I think these features are necessary for an Ellipsis component:
I can make a pr with pleasure if in need.
The text was updated successfully, but these errors were encountered: