Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onClick event on table row #8

Closed
martinsura opened this issue Jun 6, 2021 · 3 comments
Closed

Add onClick event on table row #8

martinsura opened this issue Jun 6, 2021 · 3 comments
Labels
feature request New feature or request

Comments

@martinsura
Copy link

What problem does the feature solve?

Hello,

Really nice library. Thanks for sharing.

Playing around with table component and not able handle onClick event on table row. Documentation says there is only one event onSelect in selection mode but this is other usecase.

What does the proposed API look like?

Just propagate event on table props ( onRowSelect:(record:T(any)) => void; )

Btw really nice styles - so clean! Gj

@07akioni
Copy link
Collaborator

07akioni commented Jun 7, 2021

Thanks. I've add row-props prop on DataTable. It will be released in next version.

solved in 15ae234

@07akioni 07akioni added the feature request New feature or request label Jun 7, 2021
@07akioni
Copy link
Collaborator

07akioni commented Jun 7, 2021

If you have time could you please adding test for it. 😂

@07akioni 07akioni closed this as completed Jun 7, 2021
@martinsura
Copy link
Author

Haha sure. I have one pet project so maybe next weekend i will test it. Ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants