Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New prop of cards #83

Closed
XieZongChen opened this issue Jun 11, 2021 · 3 comments
Closed

New prop of cards #83

XieZongChen opened this issue Jun 11, 2021 · 3 comments

Comments

@XieZongChen
Copy link
Collaborator

XieZongChen commented Jun 11, 2021

What problem does the feature solve?

I think the card component can add a prop to control the shadow effect of the card, like:

image

This prop can replace the current hoverable prop.

What does the proposed API look like?

<n-card shadow="never">
  ...
</n-card>
Name Type Default
shadow 'always' | 'hover' | 'never' 'never'
@07akioni
Copy link
Collaborator

An always shadowed card is not commonly used. Could you give some convincing use cases?

@XieZongChen
Copy link
Collaborator Author

Sorry, I didn't find a convincing use case, but from the perspective of design language, it's a good idea to write a piece of important content on a shadowed card when I want to improve the user's attention, which will make the website more hierarchical.

@07akioni
Copy link
Collaborator

Sorry, I didn't find a convincing use case, but from the perspective of design language, it's a good idea to write a piece of important content on a shadowed card when I want to improve the user's attention, which will make the website more hierarchical.

I think it may not help user since their designer will propose various box-shadow, thus they have to write custom css instead of using a built in prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants