Support for multiple files - input as a file list - using -f flag #21
Conversation
cibinjoseph
changed the title
cibinjoseph
changed the title
| pdf_file = get_output_file(args.filename, args.outputfile) | ||
| pdf = Code2pdf(args.filename, pdf_file, args.size) | ||
| pdf.init_print(linenos=args.linenos, style=args.style) | ||
| else: |
There was a problem hiding this comment.
@cibinjoseph Hi! Can we add a test suite for your changes before we merge? Also, update the usage/argparser instructions accordingly. Thanks! :)
There was a problem hiding this comment.
(On the test suite) Sure! How do you wanna go about it?
And I had already updated the argparser instructions in the commit.
There was a problem hiding this comment.
I'll edit the 'usage' section in a while!
There was a problem hiding this comment.
@cibinjoseph You may find some test suit written under tests/test.py. You may add yours there as well.
|
I'd also like to add a flag (later) for the pdf document-created from multiple file sources-to be a single file. Would be useful for creating documentation type pdfs. Something similar to example.pdf provided by lucascaton/code2pdf |
| pdf = Code2pdf(args.filename, pdf_file, args.size) | ||
| pdf.init_print(linenos=args.linenos, style=args.style) | ||
| else: | ||
| with open(args.filename) as filelist: |
There was a problem hiding this comment.
@cibinjoseph I doubt here with open would work this way. It expects a string or buffer and not a list. Even if type of filename is not a list but a string, you may still want to split the filenames and feed to open separately.
Anyway, that's why I asked for a test suite. :)
There was a problem hiding this comment.
It seems to work for me.
open(args.filename) as filelist: opens the file that contains the list of file names.
The next line filenames=filelist.read().splitlines() would parse filelist for the names of the files and then store it as a list in filenames.
And yes, I did want to finish the test suite but got caught up with some work. Don't accept without the test suite! :D
There was a problem hiding this comment.
I remember getting a segmentation fault from PyQT after the program run (for the copy in your repo too). That seemed to deter me from working on the test suite. Have to check if it still exists when PyQT is compiled from scratch.
There was a problem hiding this comment.
@cibinjoseph Cool! I misunderstood filename being comma separated list of file names passed as a console arg. :)
Please feel free to look into the seg fault issue as I've not been able to investigate myself due to work commitments. I believe there is already an issue created by you for this.
Also, to be consistent, I will go ahead with your current PR once you've added the suite. Thanks!
Added
-for--filelistflag that acceptsfilenameto be a file containing list of file names to be converted to pdf format.Usage:
code2pdf -f list_of_fileswhere the file
list_of_filescontains file names of files to be converted to pdf format.Caveats: This will not work if QT pops segfault