-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
youtube url #39
Comments
@martingg88 The real problem is that this module doesn't support HTTPS out of the box. It would be great if you could send a pull request for the same or I can make you the collaborater. I am also thinking of re-writing this module from scratch. |
i'm regret to tell you that i have not idea how to write this module. sorry |
what about you give me the system flow for this library, so i can try to write to support HTTPS? |
@martingg88 I have made a lot of changes since your last message. Checkout the develop branch. Its a complete re-write, using a pub-sub approach. Unfortunately all the features have not been implemented. Though this supports HTTPS, it doesn't support stopping of a download or download concurrently, both of which should be extremely easy to implement. It would be great if you can continue from here instead of the master branch. The code is concise and much easier to read. |
what about integrate with this "node-fast-download" and add the level to make it support of multiple thread? |
@martingg88 I have been really busy man. In between jobs and so I really apologise for ruining the trust you have put in this piece of software. I know you must be really pissed. I will fix this I promise. Give me sometime. |
don't worry guy. i'm understand your situation. let's take your time. |
This issue is resolved in the develop branch, could you try once again, so that I could close this ticket? |
I was able to download files over https sucessfully. Hence closing the ticket |
seem like it doesn't download youtube mp4 video. You can try with following link and it doesn't work. any idea? FYI. the following link will work with wget. Maybe we need the --no-check-certificate option?
https://lh3.googleusercontent.com/xTMukQfobC193nsiO3K78vhxoaLyt5trzxOk4V3Wmw=m18
The text was updated successfully, but these errors were encountered: