Android apk failed to build for F-Droid

[Kingwad]

• [ X ] This is not a feature request (existing functionality does not work, not missing functionality).
  I will request features on forum or via support.
• [ X ] I've searched and did not find a similar issue.

Bug in mobile app

Describe the bug
Android version 3.75.3 failed to build for the F-Droid repository. The repository contains 3.73.1 as the latest version

To Reproduce

See the errors from f-droid https://f-droid.org/wiki/page/de.tutao.tutanota/lastbuild_375030

== Installed Android Tools ==

INFO: Creating log directory
INFO: Creating temporary directory
INFO: Creating output directory
INFO: Using git version 2.11.0
INFO: Building version 3.75.3 (375030) of de.tutao.tutanota
INFO: Running 'sudo' commands in /home/vagrant
INFO: Getting source for revision tutanota-android-release-3.75.3
INFO: Creating local.properties file at build/de.tutao.tutanota/local.properties
INFO: Creating local.properties file at build/de.tutao.tutanota/app-android/local.properties
INFO: Creating local.properties file at build/de.tutao.tutanota/app-android/app/local.properties
INFO: Running 'prebuild' commands in build/de.tutao.tutanota/app-android/app
INFO: Cleaning Gradle project...
INFO: Scanning source for common problems...
INFO: Removing gradle-wrapper.jar at app-android/gradle/wrapper/gradle-wrapper.jar
ERROR: Found ZIP file archive at node_modules/mithril/dist/archive/v0.1/mithril.min.zip
ERROR: Found ZIP file archive at node_modules/mithril/dist/archive/v0.1.1/mithril.min.zip
ERROR: Found gzip file archive at node_modules/semver/semver.min.js.gz
ERROR: Found gzip file archive at node_modules/semver/semver.browser.js.gz
ERROR: Could not build app de.tutao.tutanota: Can't build due to 4 errors while scanning

Expected behavior
F-Droid should have the latest version available, 3.75.3

[charlag]

Thanks for the report. I do not understand at all why there should be zips with old mithril versions there or why should this be a problem.

[charlag]

Very nice of them to change the scanner and not check whether it breaks something:
https://gitlab.com/fdroid/fdroidserver/-/commit/6590f3869e5f4ed231ad69343735250d46dc9833

[charlag]

I sent MR
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/7133

[charlag]

They fixed it on their own too
https://gitlab.com/fdroid/fdroiddata/-/merge_requests/7133

[QGB]

2023-09-27 23:23:59,564 INFO: Scanning source for common problems...
2023-09-27 23:24:00,112 INFO: Removing gradle-wrapper.jar at fenix/gradle/wrapper/gradle-wrapper.jar
2023-09-27 23:24:01,062 ERROR: Found usual suspect 'firebase' at android-components/components/lib/push-firebase/build.gradle
2023-09-27 23:24:02,158 INFO: Removing gradle-wrapper.jar at android-components/gradle/wrapper/gradle-wrapper.jar
2023-09-27 23:24:02,179 ERROR: Unused scanignore path: android-components/components/lib/publicsuffixlist/src/main/assets/publicsuffixes
2023-09-27 23:24:02,180 ERROR: Could not build app org.mozilla.fennec_fdroid: Can't build due to 2 errors while scanning
2023-09-27 23:24:02,185 INFO: Finished

To fix , modify metadata/org.mozilla.fennec_fdroid.yml :

prebuild: $$MozBuild$$/prebuild.sh $$VERSION$$ $$VERCODE$$
    scanignore:
      - android-components/components/lib/push-firebase
    build: $$MozBuild$$/build.sh
    ndk: r21d

[charlag]

@QGB isn't it about fennec? we don't use Firebase