Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow failures are not detected for admin client build in CI #3442

Closed
rosso-ptg opened this issue Aug 31, 2021 · 0 comments
Closed

Flow failures are not detected for admin client build in CI #3442

rosso-ptg opened this issue Aug 31, 2021 · 0 comments
Labels
bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci) state:done meets our definition of done state:tested We tested it and are about to release it
Projects
Build team backlog
Milestone
3.88.0

Comments

@rosso-ptg
Copy link

rosso-ptg commented Aug 31, 2021 •
edited

When building admin client in CI, the CI job will succeed even if there are flow errors. This is most likely related to the way that flow is called in make.js. It seems that flow might be reusing some existing flow server instance whose caches are not properly invalidated. It could also be that make.js simply does not terminate with the expected return value when flow errors occur.

NOTE
see PR 19 in tutanota-next for the changes
@rosso-ptg rosso-ptg added bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci) labels Aug 31, 2021
@rosso-ptg rosso-ptg added this to To do in Build team backlog Aug 31, 2021
@rosso-ptg rosso-ptg changed the title Flow failures are not detect for admin client build in CI Flow failures are not detected for admin client build in CI Aug 31, 2021
@rosso-ptg rosso-ptg moved this from To do to In progress in Build team backlog Sep 6, 2021
@rosso-ptg rosso-ptg added the state:done meets our definition of done label Sep 6, 2021
@rosso-ptg rosso-ptg moved this from In progress to Reviewer approved in Build team backlog Sep 6, 2021
@rosso-ptg rosso-ptg added this to the Next release milestone Sep 6, 2021
@bedhub bedhub modified the milestones: Next release, 3.87.3 Sep 7, 2021
Build team backlog automation moved this from Reviewer approved to Done Sep 7, 2021
@vaf-hub vaf-hub added the state:tested We tested it and are about to release it label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors build issues that concern the build process (not only ci) state:done meets our definition of done state:tested We tested it and are about to release it
Projects
Build team backlog
Done
Milestone
3.88.0
Development

No branches or pull requests
3 participants
@rosso-ptg @bedhub @vaf-hub