Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription changes #3918

Merged
merged 5 commits into from Feb 23, 2022
Merged

Subscription changes #3918

merged 5 commits into from Feb 23, 2022

Conversation

charlag
Copy link
Contributor

@charlag charlag commented Feb 23, 2022 •
edited by sarashub

tutao/private-issues#6

Test notes

  • Order a feature (e.g. whitelabel), check that the price is correct
  • Unorder a feature (e.g. whitelabel), check that the price decreases
  • Order users, check that whitelabel increases the price and is listed under features

@charlag charlag linked an issue Feb 23, 2022 that may be closed by this pull request
Cancelling keychain prompt during credential migration leads to the blank screen #3878
Open
@charlag charlag removed a link to an issue Feb 23, 2022
Cancelling keychain prompt during credential migration leads to the blank screen #3878
Open
johnbotris
johnbotris approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@johnbotris johnbotris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good

@johnbotris johnbotris merged commit e2eb2a9 into master Feb 23, 2022
@johnbotris johnbotris deleted the subscription-terms branch February 23, 2022 16:10
@johnbotris johnbotris added this to the 3.93.0 milestone Feb 24, 2022
@sarashub
Copy link
Contributor

When ordering a user an incorrect price is shown.

@sarashub sarashub added the state:tested We tested it and are about to release it label Mar 1, 2022
@sarashub sarashub removed their assignment Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbotris johnbotris johnbotris approved these changes

Assignees
No one assigned
Labels
state:tested We tested it and are about to release it
Projects
None yet
Milestone
3.93.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@charlag @sarashub @johnbotris