Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow checking arbitrary domain records #5043

Merged
merged 1 commit into from Feb 3, 2023

Conversation

paw-hub
Copy link
Contributor

@paw-hub paw-hub commented Jan 25, 2023

Add customer ID as an optional field for support to assist with custom domain troubleshooting.

tutadb#1299

Test notes

  • Go to a customer in the admin client and click "Check DNS records for another domain...". Enter "gmail.com" and take note of t-verify value displayed.
    • Log into this customer in the Tutanota client, attempt to add "gmail.com" as a custom domain, and verify that it wants the same t-verify value to be added.
  • Go to a different customer. Enter "gmail.com" in the admin client and verify it shows the same information except for a different hash after t-verify.
    • For the same customer, enter "hotmail.com" in the admin client and verify it still shows a different t-verify value.

@ganthern
Copy link
Contributor

  • I'll need some test notes
  • what's up with all the models suddenly being compatible since version 0? has something changed here?

@mpfau
Copy link
Contributor

mpfau commented Jan 31, 2023

What puzzles me is that we remove schemas for already outdated sys/storage and tutanota models.

@ganthern do you have an idea on how that could happen?

@paw-hub paw-hub force-pushed the check-records-of-arbitrary-domain-1299 branch 2 times, most recently from aaebbcf to 62f3154 Compare February 1, 2023 09:29
@paw-hub
Copy link
Contributor Author

paw-hub commented Feb 1, 2023

The issue was due to a change in SchemeGenerator.js#isPersistentType that was there for some reason. Vitor and I discussed it and were not sure why it was there besides maybe trying to work around a compile error after rebase for some reason, so we rolled it back.

It should be fixed in the model now. Thanks for catching that!

@mpfau mpfau added this to the 3.109.0 milestone Feb 3, 2023
@mpfau mpfau enabled auto-merge (rebase) February 3, 2023 14:38
Add customer ID as an optional field for support to assist with custom
domain troubleshooting.

tutadb#1299
@mpfau mpfau force-pushed the check-records-of-arbitrary-domain-1299 branch from 62f3154 to 7687d73 Compare February 3, 2023 14:41
@mpfau mpfau merged commit a0cfbd6 into master Feb 3, 2023
@mpfau mpfau deleted the check-records-of-arbitrary-domain-1299 branch February 3, 2023 14:44
@mpfau mpfau self-assigned this Feb 6, 2023
@mpfau mpfau added the state:tested We tested it and are about to release it label Feb 6, 2023
@mpfau mpfau removed their assignment Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants