Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox misplaced when paired with a long label #6309

Closed
6 tasks done
rezbyte opened this issue Dec 15, 2023 · 0 comments · Fixed by #6314
Closed
6 tasks done

Checkbox misplaced when paired with a long label #6309

rezbyte opened this issue Dec 15, 2023 · 0 comments · Fixed by #6314
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it ui visual glitches, missing buttons, wrong text...
Milestone

Comments

@rezbyte
Copy link
Contributor

rezbyte commented Dec 15, 2023

Describe the bug
The checkboxes in the sign up are misplaced when their labels are too long for the dialog. This happens to the English version of the terms & conditions checkbox in the sign up model & the German version of confirmation dialog.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the 2nd stage of the sign up modal
  2. See the the checkbox is misaligned

Expected behavior
The checkbox stays to the left of the label.

Screenshots
Wire 2023-12-15 at 4_15 PM
Wire 2023-12-15 at 4_15 PM-2

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Firefox
  • Version 120

Additional context
Brought to my attention from @kibhub via @charlag.

Test Notes

  • Check button can still be disabled
  • Terms and conditions checkbox when purchasing or redeeming gift cards is styled correctly
  • When a checkbox has a single word label bigger than its container, it word wraps by character
  • When a checkbox has a multiple word label bigger than its container, it word wraps by word
  • Checkbox still reads correctly on TalkBack (the Android screen reader) & VoiceOver (the iOS screen reader)
  • External content SVG still displays correctly
@rezbyte rezbyte added bug broken functionality, usability problems, unexpected errors ui visual glitches, missing buttons, wrong text... labels Dec 15, 2023
@rezbyte rezbyte self-assigned this Dec 15, 2023
@ganthern ganthern added this to the 3.119.9 milestone Dec 20, 2023
@ganthern ganthern added the state:done meets our definition of done label Dec 20, 2023
@ganthern ganthern added state:tested We tested it and are about to release it and removed state:done meets our definition of done labels Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug broken functionality, usability problems, unexpected errors state:tested We tested it and are about to release it ui visual glitches, missing buttons, wrong text...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants