Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time picker for creating events does not respect time format setting #6339

Closed
3 of 7 tasks
kib42 opened this issue Dec 29, 2023 · 1 comment · Fixed by #6752
Closed
3 of 7 tasks

time picker for creating events does not respect time format setting #6339

kib42 opened this issue Dec 29, 2023 · 1 comment · Fixed by #6752
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it topic: calendar ui visual glitches, missing buttons, wrong text...
Milestone

Comments

@kib42
Copy link

kib42 commented Dec 29, 2023

setting the time format to 24-hour format does not change the time picker. This happens on Android only since v3.119.3

image
image

Test notes

  • On Android and iOS,
    • When the time format is set to 12 hours in the app's settings, the time picker displays in 12 hour format.
    • When the time format is set to 24 hours in the app's settings, the time picker displays in 24 hour format.
    • You can click on the time picker to open the time picker dialog. Note that it will not follow the time format settings.
  • On Desktop/Web app,
    • When the time format is set to 12 hours in the app's settings, the time picker displays in 12 hour format.
    • When the time format is set to 24 hours in the app's settings, the time picker displays in 24 hour format.
@kib42 kib42 added bug broken functionality, usability problems, unexpected errors topic: calendar ui visual glitches, missing buttons, wrong text... android issues that concern the android client but not all clients labels Dec 29, 2023
@rezbyte
Copy link
Contributor

rezbyte commented Mar 19, 2024

I have reproduced this on the latest testing android build. However, it also reproduces on versions before v3.119.3 and on iOS. From reading the codebase, the native time picker should not have been able to display the right time format to begin with. The <input type="time"> chooses between time formats solely on system locale as seen in navigator.language. The time format drop-down in settings does not change the system locale at all. It is possible on Android 13 but no version of iOS to set the locale by app, but this does not fix it for the oldest supported version of Android (Android 12) and iOS users.

To fix this, I can think of two options:

  1. Disable the time format settings on Mobile and get the time format to display times from the OS settings.
  2. Program manual calls to open a native time picker so we can use its time format parameter, and to get the selected time back.

Edit: @paw-hub suggested using our custom time picker instead of the native time picker.

@wrdhub wrdhub added the state:done meets our definition of done label Mar 26, 2024
@murilopereirame murilopereirame added this to the 220.240321.0+ milestone Mar 27, 2024
@murilopereirame murilopereirame self-assigned this Apr 2, 2024
@murilopereirame murilopereirame added the state:tested We tested it and are about to release it label Apr 2, 2024
@murilopereirame murilopereirame removed their assignment Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android issues that concern the android client but not all clients bug broken functionality, usability problems, unexpected errors state:done meets our definition of done state:tested We tested it and are about to release it topic: calendar ui visual glitches, missing buttons, wrong text...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants