Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 404 page not shown for paths with more than one slash #6791

Conversation

jomapp
Copy link
Contributor

@jomapp jomapp commented Mar 26, 2024

We do not show the 404 page on the webapp correctly if paths that did not exist include more than one slash.
e.g. /test/test.

Test Notes:

@jomapp jomapp added the state:done meets our definition of done label Mar 26, 2024
@jomapp jomapp assigned jomapp and unassigned jomapp Mar 26, 2024
@charlag charlag added this to the 220.240321.0+ milestone Mar 26, 2024
@murilopereirame murilopereirame added this pull request to the merge queue Mar 27, 2024
Merged via the queue into master with commit a07af3e Mar 27, 2024
2 checks passed
@murilopereirame murilopereirame deleted the fix-404-page-not-shown-for-paths-with-more-than-one-slash branch March 27, 2024 09:38
@rezbyte rezbyte self-assigned this Mar 28, 2024
@rezbyte rezbyte added the state:tested We tested it and are about to release it label Mar 28, 2024
@rezbyte rezbyte removed their assignment Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:done meets our definition of done state:tested We tested it and are about to release it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants