Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lxml to ^5.0.0 #4

Closed
Antyos opened this issue May 7, 2024 · 4 comments
Closed

Bump lxml to ^5.0.0 #4

Antyos opened this issue May 7, 2024 · 4 comments

Comments

@Antyos
Copy link

Antyos commented May 7, 2024

Issue

Currently, this library cannot be added to projects which use lxml >= 5.0.0.

$ poetry add mkdocs-drawio -G docs     
Using version ^1.6.0 for mkdocs-drawio

Updating dependencies
Resolving dependencies... (0.0s)

Because no versions of mkdocs-drawio match >1.6.0,<2.0.0
 and mkdocs-drawio (1.6.0) depends on lxml (>=4.9.0,<5.0.0), mkdocs-drawio (>=1.6.0,<2.0.0) requires lxml (>=4.9.0,<5.0.0).
So, because my-project depends on both lxml (^5.1.0) and mkdocs-drawio (^1.6.0), version solving failed.

Solution

I suspect this is due to the packaging constraints in the pyproject.toml:

lxml = "^4.9.0"
.

From what I can tell, there is no need to limit the library to lxml 4.9, other than that was what was used at the time of the library's creation, so allowing anything above 4.9 should be fine. I would make a PR, but I am slightly confused as to how Poetry is being used in this repo; Poetry is not included in the dev container or the GitHub Actions workflow, so I don't know where/how the lxml version constraint was introduced.

If you are using Poetry for versioning, you should be able to replace the line noted above with:

lxml = ">=4.9.0"
@tuunit
Copy link
Owner

tuunit commented May 7, 2024

Thanks for opening the issue.
Release 1.6.1 is now available with all dependencies upgraded.

Please try again.

@tuunit
Copy link
Owner

tuunit commented May 7, 2024

Maybe I make another release to be less restrictive with the versions instead of forcing the latest newer version for all dependencies

@Antyos
Copy link
Author

Antyos commented May 8, 2024

It works! Thank you so much!

Maybe I make another release to be less restrictive with the versions instead of forcing the latest newer version for all dependencies

I am in favor of this. Take a look at: https://python-poetry.org/docs/dependency-specification/ for how to specify less restrictive versions.

@tuunit
Copy link
Owner

tuunit commented May 9, 2024

@tuunit tuunit closed this as completed May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants