Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchToken() is not compatible with Slim's cookie encryption #10

Closed
Soulriser opened this issue Oct 1, 2015 · 3 comments
Closed

fetchToken() is not compatible with Slim's cookie encryption #10

Soulriser opened this issue Oct 1, 2015 · 3 comments

Comments

@Soulriser
Copy link

For example, the return value for fetchToken() is return $_COOKIE[$this->options["cookie"]];, but this direct access of $_COOKIE invalidates Slim's cookie helper, including cookie encryption. This makes it impossible to use encrypted cookies for storing tokens. Shouldn't the return statement be: return $this->app->getCookie($this->options["cookie"]) ?

@tuupola tuupola closed this as completed in b7ab1d2 Oct 1, 2015
@tuupola
Copy link
Owner

tuupola commented Oct 1, 2015

This should be fixed in dev-master now. Thanks for the heads up!

@Soulriser
Copy link
Author

No problem! Thanks for the fast response.

@tuupola
Copy link
Owner

tuupola commented Oct 1, 2015

Also released as 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants