Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove stringjs dependency, add grunt-cli #10

Merged
merged 1 commit into from
Sep 22, 2018
Merged

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Sep 18, 2018

Stringjs has a high severity vulnerability, and it was trivial to remove.

@coveralls
Copy link

coveralls commented Sep 18, 2018

Coverage Status

Coverage increased (+1.6%) to 99.412% when pulling 6ebd71c on Bkucera:master into 35761cd on tuvistavie:master.

@danhper
Copy link
Owner

danhper commented Sep 20, 2018

Hi, thanks for the PR.
Is there any reason why you comitted the lib directory to git?
As it is built from src, I would rather keep it ignored unless there is a good reason not to do so.

@kuceb
Copy link
Contributor Author

kuceb commented Sep 21, 2018

@tuvistavie yea, I committed that on my fork so I could directly ref my source as the npm package version. Didn't mean for that to show up here 😄

edit: fixed

@danhper
Copy link
Owner

danhper commented Sep 22, 2018

Perfect, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants