Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches from AOSC-Dev #4

Open
ratijas opened this issue Jun 15, 2021 · 1 comment
Open

Patches from AOSC-Dev #4

ratijas opened this issue Jun 15, 2021 · 1 comment

Comments

@ratijas
Copy link

ratijas commented Jun 15, 2021

There are some patches in AOSC community made back in 2019 against an imported repository dating as far as version 2017.3.23. From what I can tell, they never made it here upstream. And at least one patch is a nice quality of life improvement regarding suid handling. Should we try to accept these patches now?

https://github.com/AOSC-Dev/ntfs-3g/commits/master

@Artoria2e5
Copy link

Artoria2e5 commented Sep 6, 2021

(There was some issue with the ML in that JPA and I forgot to click "reply all". So I will be quoting nonexistent stuff, sorry.)

I think AOSC-Archive/ntfs-3g@9189a4a and AOSC-Archive/ntfs-3g@c918fb7 are the two worth cherry-picking. The former is trivial and may have been independently fixed. The latter was proposed in the ML; the gist of my argument was that a system libfuse2 would be about as safe as a static libfuse-lite since the setuid on ntfs-3g prevents LD_PRELOAD and other shenanigans.

The big_writes thing is already upstream. My two commits were a bit misguided in that I basically ported libfuse3 features (the even bigger 1MB buffer) to the internal libfuse2 copy. That was obviously a bad idea compared to porting to libfuse3 wholesale, but neither Tuxera nor I had the combined energy+intention to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants