Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default conf should be all comments #195

Closed
daonb opened this issue Jan 11, 2022 · 1 comment
Closed

Default conf should be all comments #195

daonb opened this issue Jan 11, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
1.1

Comments

@daonb
Copy link
Contributor

daonb commented Jan 11, 2022 •
edited

What's missing? Please describe your flow and where this feature will help.
We should comment out all the settings and ensure they all have defaults,
this way if we change the defaults in future version (as we're doing with shell)
most users won't feel the change

Additional context
Add any other context or screen diagrams shots about the feature request here.
@daonb daonb added the enhancement New feature or request label Jan 11, 2022
@daonb daonb changed the title Use sensible defaults & use "*" for shell Default conf should be all comments Jul 20, 2022
@daonb daonb added this to the 1.0.0 milestone Jul 27, 2022
@daonb daonb modified the milestones: 1.0.0, 1.1 Sep 6, 2022
@daonb
Copy link
Contributor Author

daonb commented Sep 29, 2022

It's done

@daonb daonb closed this as completed Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.1
Development

No branches or pull requests
1 participant
@daonb