Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare password functionality #39

Merged
merged 1 commit into from
May 25, 2022
Merged

compare password functionality #39

merged 1 commit into from
May 25, 2022

Conversation

ywegel
Copy link
Contributor

@ywegel ywegel commented May 24, 2022

I have now implemented a method called compare_password(). It is located both in the Auth and User guard. I implemented it in both, so that you can decide where it is more useful. I myself think it is better to have it in the User guard, because that makes sure that a logged in user exists, but that is up to you to decide. The function was also tested in one of my projects, where i temporary used my fork of rocket_auth as a dependencie. The documentation and function name is just an idea, feel free to change it :)

If you think it should be implemented otherwise, write a comment i will fix it

@ywegel ywegel changed the title compare password function compare password functionality May 24, 2022
@tvallotton
Copy link
Owner

It looks good. Now, I have a couple of minor edits I would make, do you prefer I list them here so you can do them or is it ok if I do them and push them to a separate branch?

@ywegel
Copy link
Contributor Author

ywegel commented May 25, 2022

Whatever you prefer:)
If you don't have time for it i can do it, but i don't mind if you do it

@tvallotton tvallotton merged commit cc12367 into tvallotton:next May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants