Derestrict rusqlite dependency version #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes depending _exactly_ on rusqlite 0.25.3 (which has been [yanked](https://crates.io/crates/rusqlite/0.25.3) btw). From quick testing, depending on the latest version (0.27.0) works too, so alternatively, you could change the version to be `0.27.0` rather than this commit's suggestion.
|
I think I prefer having a specific version so to avoid possible breakage in the future. Thanks for making me aware of this. |
|
Sounds good thanks, closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes depending exactly on rusqlite 0.25.3 (which has been yanked btw).
From quick testing, depending on the latest version (0.27.0) works too, so alternatively, you could change the version to be
0.27.0rather than this commit's suggestion.As an alternative, running
cargo upgradeto update all dependencies to latest versions, it seems like everything builds fine (and the tests seem to produce some minor fixable suggestions), so maybe if making a new release, it might be good to update all dependencies. Happy to make a separate PR if you think it would be useful.Thanks for this project btw! :)