Tb/action emphase #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new icon looks great :-) |
| <FrameLayout | ||
| android:id="@+id/view_palette_list_empty_view" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent"> |
There was a problem hiding this comment.
I don't really see the need of a FrameLayout here, Couldn't we simply use an ImageView that matches its parent and have a scaleType centerInside ?
There was a problem hiding this comment.
sure I totally forgot to remove that. Initially, a additionnal arrow was also contained by this FrameLayout. Gonna removed it right now.
tbarthel-fr
force-pushed
the
tb/action-emphase
branch
from
cf28181
to
a1dc6b5
Compare
|
@vbarthel-fr both useless FrameLayout from color and palette layout has been removed (= Let you review and merge if it sounds good to you. |
|
lgtm 👍 @tbarthel-fr some conflitcs must be resolved before merging. |
Use the drop figure in the launcher icon. Use the drop figure as text replacement for empty views.
tbarthel-fr
force-pushed
the
tb/action-emphase
branch
from
a1dc6b5
to
5e15712
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Animations has been added for every users.
In addition, drop figure has been added for kids and used in the ic_launcher as well as empty view indicator.
icons:
for kids :
default :
