[Color items] Adapts the color item list to the kids/adult flavors. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ColorItemListWrapper desribes the common contract of the wrapper. The FlavorColorItemListWrapper defines the specific behaviors. For the kids flavor, the items are presented in a grid. Only a preview of the color is presented. For the adult flavor, the items are presented in a vertical list. The hexadecimal code id displayed next to the color. A long press on the row will copy the hexadecimal code to the clipboard.
|
Looks great :-) Would it be possible to remove the text "New palette" from the ActionBar also? |
|
Absolutely, but this will be part of another MR =) This MR only focus on the color item lists. We split the work into small MR so that it is easier for us to divide the tasks and for you to see what changes =) |
|
lgtm 👾 |
|
@vbarthel-fr Ok, good strategy :-) I think the new item list looks very intuitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR is an attempt to adapt the color item lists for kids.
In the kids version of the app, the color items are now displayed as a grid. The hexadecimal codes are no longer shown. And long press actions for copying the hexa codes to the clip board has been disabled.
Here are some screenshots of the default version:
And here are some screenshots of the kids version:
Once this MR is validated, I will adapt the palette lists in the same way =)